-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PyData Sphinx Theme pin #161
Conversation
Includes fixes for the primary sidebar compatible with PST 0.15.3
* use setuptools_scm for versioning * ensure checkout depth is correctly set * remove problematic [tool.setuptools.dynamic]
That did not fix the nav bar decoration 😢 I'll come back to this tomorrow. |
I re-ran CI since 15.3 has been released.
|
Not sure what happened to the toc, but a lot has been merged in the past few days over at PST. For the other items - that's what I was trying to fix in my last commit. I'll take a look tomorrow. |
I think I got it, but we'll also need to update the docs, see napari/docs#423 |
With the latest commit to napari-docs this should be complete, including disabling the back-to-top button @jni Let me know if you see any other glaring issues before we upgrade |
I'd be ok with optimistically merging and releasing and then we see how it builds over there. |
There shouldn't be, but I'll be available to fix this weekend if that happens. |
I have the Pacific meeting with Juan (and hopefully others!) this evening, so I'll bring this up then and maybe we can get it merged and released. |
Thats up to you, I don't necessarily see an advantage in releasing without this PR |
That's what I think. 😜 |
# References and relevant issues Depends on napari/napari-sphinx-theme#161 (and a new release of the theme) # Description Restores the sidebar after the PyData Sphinx Theme is updated to version 0.15.3 --------- Co-authored-by: Juan Nunez-Iglesias <[email protected]> Co-authored-by: Peter Sobolewski <[email protected]>
Includes fixes for the primary sidebar compatible with PST 0.15.3