Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix macos x86 build and update components #364

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

lsndr
Copy link
Contributor

@lsndr lsndr commented Apr 26, 2024

GitHub is migrating macos-latest runners to ARM MacOS 14 (from x86 MacOS 12), so now it's important to specify x86 target when using macos-latest to build x86 binary.

relates-to: actions/runner-images#9642

@lsndr
Copy link
Contributor Author

lsndr commented Apr 26, 2024

Copy link
Member

@Brooooooklyn Brooooooklyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Brooooooklyn Brooooooklyn changed the title ci: add target to macos x86 build ci: fix macos x86 build and update components Apr 28, 2024
@Brooooooklyn Brooooooklyn merged commit 299e2a6 into napi-rs:main Apr 28, 2024
30 checks passed
@thewh1teagle
Copy link

It causing my build to failed, because when passing --platform the output dir is so it doesn't find the .node file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants