Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add listener close function #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dmorn
Copy link

@dmorn dmorn commented Mar 17, 2020

Close #26.

I'm doing graceful shutdowns by wrapping the RTMP server and adding context to the ListenAndServe function

func (s *Server) ListenAndServe(ctx context.Context) error {
	go func() {
		<-ctx.Done()
		s.rtmps.Close()
	}()
	return s.rtmps.ListenAndServe()
}

When the context is canceled, ListenAndServe will stop blocking.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
dmorn Daniel Morandini
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close() on RTMP server
1 participant