Skip to content

Commit

Permalink
better hints
Browse files Browse the repository at this point in the history
  • Loading branch information
MarcoGorelli committed Dec 29, 2024
1 parent c460e28 commit 40a0151
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion narwhals/expr.py
Original file line number Diff line number Diff line change
Expand Up @@ -1666,7 +1666,10 @@ def sort(self, *, descending: bool = False, nulls_last: bool = False) -> Self:

# --- transform ---
def is_between(
self, lower_bound: Any | Self, upper_bound: Any | Self, closed: str = "both"
self,
lower_bound: Any | IntoExpr,
upper_bound: Any | IntoExpr,
closed: str = "both",
) -> Self:
"""Check if this expression is between the given lower and upper bounds.
Expand Down
2 changes: 1 addition & 1 deletion narwhals/series.py
Original file line number Diff line number Diff line change
Expand Up @@ -2069,7 +2069,7 @@ def fill_null(
)

def is_between(
self, lower_bound: Any, upper_bound: Any, closed: str = "both"
self, lower_bound: Any | Self, upper_bound: Any | Self, closed: str = "both"
) -> Self:
"""Get a boolean mask of the values that are between the given lower/upper bounds.
Expand Down

0 comments on commit 40a0151

Please sign in to comment.