-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking βSign up for GitHubβ, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add few missing SparkLikeExpr
methods
#1721
Merged
FBruzzesi
merged 11 commits into
narwhals-dev:main
from
Dhanunjaya-Elluri:feat/spark-expr-methods
Jan 7, 2025
+323
β26
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ea03eaf
feat(spark): add missing methods to SparkLikeExpr
Dhanunjaya-Elluri 57ab8a0
feat(spark): add few missing methods
Dhanunjaya-Elluri f3ab9e2
fix: add xfail to median when python<3.9
Dhanunjaya-Elluri c470ece
fix: fixing reviewd requests & updated tests
Dhanunjaya-Elluri e569f83
fix: fix `PYSPARK_VERSION` for `median` calculation
Dhanunjaya-Elluri 120ea3b
fix: fix refactor issue
Dhanunjaya-Elluri b00c6dc
fix: remove `is_nan` method
Dhanunjaya-Elluri fbdd61c
Merge branch 'main' of https://github.com/Dhanunjaya-Elluri/narwhals β¦
Dhanunjaya-Elluri 6e8292b
Merge branch 'main' of https://github.com/Dhanunjaya-Elluri/narwhals β¦
Dhanunjaya-Elluri 9ac23e6
fix: fixing `is_duplicated` & `is_unique` & remove `n_unique`
Dhanunjaya-Elluri 155f654
Merge branch 'main' into feat/spark-expr-methods
FBruzzesi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: fix
PYSPARK_VERSION
for median
calculation
commit e569f838113f020b35fc2a9edb359d859bc97d1e
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should narwhals suggest (and maintain :)) a guide to install Java for pyspark?
Or should we just add a note to say that pyspark needs Java and add a link to the pyspark documentation?
There may be different ways one wants to install Java on their machine.
For example, on macOS I prefer using openjdk installed via homebrew.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be simple to just say that pyspark needs java installed and add a link to pyspark documentation.