Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dask in api-completeness table #741

Merged
merged 8 commits into from
Aug 22, 2024
Merged

Conversation

FBruzzesi
Copy link
Member

@FBruzzesi FBruzzesi commented Aug 7, 2024

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

Adds dask in api-completeness doc page: I think it will be a easy entrypoint to easily see what's still missing from the API.

In terms of script and final output, I will try to spend some time and give it some more love in the near future πŸ˜‡

Ok so it was quicker and simpler than excepted. The new script generate 3 files (dataframe.md, expr.md and series.md) into the api-completeness folder dynamically. There are still some improvements to be made (e.g. lazy vs eager)

@github-actions github-actions bot added the enhancement New feature or request label Aug 7, 2024
@MarcoGorelli
Copy link
Member

nice πŸ™ ! we're not currently mentioning Dask at all in the docs, perhaps let's get a little further before merging this?

@FBruzzesi
Copy link
Member Author

nice πŸ™ ! we're not currently mentioning Dask at all in the docs, perhaps let's get a little further before merging this?

Sure, let's do that! This will have no conflicts with the main codebase anyway :)

@MarcoGorelli
Copy link
Member

we're probably far enough with Dask that we can merge this?

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving then, feel free to merge if you agree

@FBruzzesi FBruzzesi merged commit 949d5b6 into main Aug 22, 2024
24 checks passed
@FBruzzesi FBruzzesi deleted the feat/dask-api-completeness branch August 22, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants