Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add narwhals_gif README.md #841

Closed
wants to merge 1 commit into from
Closed

add narwhals_gif README.md #841

wants to merge 1 commit into from

Conversation

anopsy
Copy link
Member

@anopsy anopsy commented Aug 21, 2024

Does it look okayish?

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

  • Related issue #
  • Closes #

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

@MarcoGorelli
Copy link
Member

πŸ˜„ love the idea, nice one! and good placement in the readme

a couple of comments:

  • the text changes quite rapidly and so it's a bit hard to read
  • the Narwhals is always going to pandas, I wonder if people risk misinterpreting what Narwhals does?

@anopsy
Copy link
Member Author

anopsy commented Aug 22, 2024

πŸ˜„ aah yes! I only made one loop, it would be indeed much better to make the Narwhals visit multiple backends. I'll also adjust the speed

@anopsy anopsy closed this Aug 22, 2024
@FBruzzesi FBruzzesi deleted the anopsy-patch-1 branch September 23, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants