Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove to_numpy and to_list in tests #842

Merged
merged 3 commits into from
Aug 22, 2024
Merged

test: remove to_numpy and to_list in tests #842

merged 3 commits into from
Aug 22, 2024

Conversation

FBruzzesi
Copy link
Member

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

Tiny trick for pyarrow using str(value)

@MarcoGorelli
Copy link
Member

cool, thanks! just looks like some coverage issue

narwhals/_arrow/series.py           540      1     44      0    99%   315
narwhals/_pandas_like/series.py     437      1     38      0    99%   200
narwhals/series.py                  270      1      6      0    99%   380

@FBruzzesi
Copy link
Member Author

FBruzzesi commented Aug 22, 2024 •
edited
Loading

Oh! We are missing coverage for to_list method now 😂 Whops

FBruzzesi
FBruzzesi commented Aug 22, 2024
View reviewed changes
tests/series_only/to_list_test.py
compare_dicts({"a": s}, {"a": [1, 2, 3]})
compare_dicts({"a": s.to_list()}, {"a": [1, 2, 3]})
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this was not supposed to be removed in the first place 😂

MarcoGorelli
MarcoGorelli approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks @FBruzzesi !

@MarcoGorelli MarcoGorelli merged commit 165e875 into main Aug 22, 2024
24 checks passed
@FBruzzesi FBruzzesi deleted the tests/rm-to-numpy-list branch August 22, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test: remove to_list() and to_numpy() from Series tests
2 participants
@FBruzzesi @MarcoGorelli