Os agnostic test #14
Merged
Os agnostic test #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
=======================================
Coverage 90.90% 90.90%
=======================================
Files 1 1
Lines 22 22
Branches 3 3
=======================================
Hits 20 20
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
lpsinger
added a commit
to lpsinger/dynamodb-autoincrement
that referenced
this pull request
Oct 4, 2023
See nasa-gcn/gcn.nasa.gov#1477. Note that Windows builds will initially fail; see nasa-gcn#14.
lpsinger
reviewed
Oct 4, 2023
There was a problem hiding this comment.
Do you know why the Windows tests are already passing on #15 but evidently not on your laptop, @dakota002? Are you lacking the test, mkdir, or curl commands?
|
Please rebase to trigger the tests on Windows and macOS. |
|
Will do, and yes, the |
dakota002
force-pushed
the
OSAgnosticTest
branch
from
b036a60
to
843e2aa
Compare
lpsinger
requested changes
Oct 4, 2023
lpsinger
requested changes
Oct 5, 2023
lpsinger
approved these changes
Oct 5, 2023
lpsinger
added a commit
to lpsinger/dynamodb-autoincrement
that referenced
this pull request
Oct 16, 2023
The `setup-dynamodb-local.mjs` script, introduced in nasa-gcn#14, requires the web fetch API, which requireds Node >= 18.
lpsinger
added a commit
to lpsinger/dynamodb-autoincrement
that referenced
this pull request
Oct 16, 2023
The `setup-dynamodb-local.mjs` script, introduced in nasa-gcn#14, requires the web fetch API, which requires Node >= 18.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.