MAXI_TEST and MAXI_UNKNOWN conversions #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicit int conversion removed MAXI_UNKNOWN conversion Removed GECAM_FLT and GECAM_GND conversion Added documentation and changed function name reformatted file deleted files
… module scope; added cross matched_flux for MAXI_TEST
|
Made an educated guess for MAXI_UNKNOWN trigger id based on the available data and comparing with text notices, it would be helpful if there was more binary data to cross-check the accuracy. I couldn't do this with MAXI_TEST since there are no text notices for those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code still does not deal with the 'id' conversions accurately. The problem is that the data stored in the packet is only the partial id and the documentation does not explain how to convert this properly. I spent sometime (a day) combing through the source code to see if I could find how this conversion is done but couldn't find how it is done.
MAXI_TEST also has flux for a cross-matched source in low, medium and high bands. There is no equivalent for these in the core schema, so I have stored these as 'source_flux_{band}' and 'background_flux_{band}' temporarily.
There are also MAXI known sources in the archive. The last one was sent 24/05/02. So maybe we are interested in converting these too?