FRB Schema for the CHIME Telescope #217
Conversation
|
Seeing many failed checks, is there action I should take on this? Cheers! |
Yes, there were some missing contributing instructions to configure pre-commit hooks. See #218. |
|
@tabbott36 A gentle reminder. Please validate it and run prettier, before we start reviewing it. |
|
Hi @tabbott36, I see from your commits that you ran the Also, I would suggest updating the names of your example files, for example: from |
|
Hi @dakota002, thanks for the help! Yes, I will revert the versioning and rename the example files. |
No problem! I have suggested a few other changes that should also fix your validation checks |
|
@tabbott36 This looks good to me now, can you please squash your commits down to 1? If you have questions on this I can assist you |
… the frb schema feat(chime/frb.schema.json): final touches on the FRB schema "properties" fix(npm): Fixed npm checks 4.2.0 Back to development Update gcn/notices/chime/frb.schema.json Co-authored-by: Dakota Dutko <[email protected]> Update gcn/notices/chime/detection.example.json Co-authored-by: Dakota Dutko <[email protected]> Update gcn/notices/chime/retraction.example.json Co-authored-by: Dakota Dutko <[email protected]> Update gcn/notices/chime/subsequent.example.json Co-authored-by: Dakota Dutko <[email protected]> Update gcn/notices/chime/update.example.json Co-authored-by: Dakota Dutko <[email protected]> fix(Versioning): reverted version number to 4.1.0 fix(version): Reverted the version to 4.1.0 using npm fix(gal_el_model-properties): corrected galactic electron density model properties fix(Data-types): Fixed incorrect data types in FRB schema
|
Sure thing! I believe it's been squashed to one commit now. Thanks! |
|
@Vidushi-GitHub @jracusin is this good now? |
We still are working on it. |
gcn/notices/chime/frb.schema.json
Outdated
| }, | ||
| "snr": { | ||
| "type": "number", | ||
| "description": "Signal-to-noise ratio of the burst" |
There was a problem hiding this comment.
Is this different from rate_snr in core/Statistics.schema.json?
| "description": "Signal-to-noise ratio of the burst" | |
| "description": "Signal-to-noise ratio of the burst [dimensionless]" |
There was a problem hiding this comment.
Thanks for the suggestion - I will add [dimensionless] to the description.
Though "snr" and "rate_snr" are very similar, I think it would be misleading to call it "rate_snr" in the context of fast radio bursts. In the high energy regime, rates is usually a measure of photon counts / time, but for radio transients, rates are usually a measure of bursts / time. In other words, a "rate_snr" for a fast radio burst might mislead people into thinking there were multiple bursts detected.
| "type": "number", | ||
| "description": "The time resolution of the real-time FRB search." | ||
| }, | ||
| "bandwidth": { |
There was a problem hiding this comment.
Do you think it's same as spectrum property in core/Reporter.schema.json?
There was a problem hiding this comment.
Ah, yes, it looks like the same thing. "bandwidth" here is the frequencies over which the instrument observes, so I think it alligns well with the "spectrum" property. I'll update it! Thanks
There was a problem hiding this comment.
Looking back at this, I am noticing that "spectrum" is one of ["energy", "wavelength", "frequency"], which I originially misunderstood. Since bandwidth is a number describing the observatory's observing band, I've reintroduced it into the FRB schema.
|
Hi @tabbott36, we have added a few properties in core schema motivated from your CHIME/FRB schema, thanks! |
|
Is this FRB schema intended to be generic for other FRB experiments or specific to CHIME? |
…ons in PR nasa-gcn#217 and updated the frb example JSONs Also made modifications to the definitions of spectrum and spectral_center in the Reporter.schema.json
I've been aiming to make it generic since many other FRB detecting observatories will likely be interested in eventually joining the GCN. |
Description
Added a schema for fast radio bursts (FRBs). I have also included an example json for FRB alerts from the Canadian Hydrogen Intensity Mapping Experiment (CHIME) for each alert type (detection, subsequent, retraction, and update).
Questions for GCN Team
Testing