Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding Core Schema for FRB #226

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Expanding Core Schema for FRB #226

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f80408b
FRB: Adding subsequent field
Vidushi-GitHub Nov 19, 2024
170b84b
no change in package.json
Vidushi-GitHub Jan 23, 2025
1732220
spectrum and spectral-center same units
Vidushi-GitHub Jan 23, 2025
efd551e
remove dm_2001 and modify spectrum section
Vidushi-GitHub Feb 12, 2025
7a93f16
Update gcn/notices/core/Reporter.schema.json
Vidushi-GitHub Feb 12, 2025
dbad11e
Update gcn/notices/core/Reporter.schema.json
Vidushi-GitHub Feb 25, 2025
f2a4e50
Update gcn/notices/core/Reporter.schema.json
Vidushi-GitHub Feb 25, 2025
66e6449
Update gcn/notices/core/Reporter.schema.json
Vidushi-GitHub Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions gcn/notices/core/DateTime.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@
"maxItems": 2,
"description": "Trigger time uncertainty [s, 1-sigma], with optional asymmetric uncertainty"
},
"time_resolution": {
"type": "number",
"description": "Time resolution used for the source search [ms]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this different from trigger_time_error?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

time_error is based on instrument time resolution.

time_resolution is choice based on transient type.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discretization is nothing more than a particular source of error. Why do we need a separate field for it?

},
"observation_start": {
"type": "string",
"description": "Start time of the observation [ISO 8601]"
Expand Down
23 changes: 23 additions & 0 deletions gcn/notices/core/DispersionMeasure.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"$id": "https://gcn.nasa.gov/schema/main/gcn/notices/core/DispersionMeasure.schema.json",
"$schema": "https://json-schema.org/draft/2020-12/schema",
"type": "object",
"title": "Schema for Radio Transients Observables",
"description": "Dispersion Measure schema used for radio transients",
"properties": {
"dm": {
"type": "number",
"description": "Dispersion measure (DM) of the burst [pc/cm^3], representing the integrated column density of free electrons along the line of sight."
},
"dm_error": {
"type": "array",
"items": { "type": "number" },
"maxItems": 2,
"description": "Uncertainity associated with the dispersion measure [pc/cm^3, 1-sigma], with optional asymmetric uncertainty."
Comment on lines +14 to +16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the asymmetric uncertainty is optional, can you please accept either an array or a number?

},
"dm_gal_ne_2001_max": {
"type": "number",
"description": "Estimated contribution to the dispersion measure [pc/cm^3] from the Galaxy using the NE2001 model."
}
}
}
6 changes: 6 additions & 0 deletions gcn/notices/core/Reporter.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@
"type": "string",
"default": "energy"
},
"spectral_center": {
"enum": ["energy", "wavelength", "frequency"],
"description": "Central value of the observing band, should have same units as spectrum",
"type": "number",
"default": "energy"
},
"units": {
"enum": ["keV", "nm", "Hz"],
"description": "Units of band range, if not parsed, then default energy is keV",
Expand Down
Loading