Add schema for the 1st SVOM notices (ECLAIRs, GRM & MXT) #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| "$id": "https://gcn.nasa.gov/schema/main/gcn/notices/svom/eclairs/eclairs.schema.json", | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "type": "object", |
There was a problem hiding this comment.
For one schema and multiple notices, add "notice_type"
"notice_type": {
"type": "string",
"enum": [
"trigger",
"catalog",
"wakeup"
],
"description": "..."
},
A bit more organized, according you need.
jracusin
reviewed
Feb 25, 2025
| "$schema": true, | ||
| "slew_status": { | ||
| "enum": ["accepted", "rejected", "not_requested"], | ||
| "description": "Whether the platform accepted or rejected a slew requested by ECLAIRs (to its best localisation). If the detection is not significant enough, this value can remain to 'not_requested'" |
There was a problem hiding this comment.
Suggested change
| "description": "Whether the platform accepted or rejected a slew requested by ECLAIRs (to its best localisation). If the detection is not significant enough, this value can remain to 'not_requested'" | |
| "description": "Whether the platform accepted or rejected a slew requested by ECLAIRs (to its best localisation). If the detection is not significant enough, this value is 'not_requested'." |
There was a problem hiding this comment.
Is there a simple prescription for the significance or a document you can reference where it's described?
jracusin
reviewed
Feb 25, 2025
Comment on lines
+18
to
+26
| "properties": { | ||
| "$schema": true, | ||
| "triggered_GRDs": { | ||
| "type": "array", | ||
| "items": { "type": "boolean" }, | ||
| "minItems": 3, | ||
| "maxItems": 3, | ||
| "description": "In case of a GRM trigger, trigger status the 3 GRDs. Each item correspond to one of the 3 GRDs: true means the GRD triggers, false not." | ||
| } |
There was a problem hiding this comment.
Consider using the DetectorStatus core schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce the SVOM notices in the common JSON format used by the NASA/GCN system.
It replaces the json schemas previously defined for SVOM notices as it was too complicated. Instead we simplify it by defining 3 schemas based on the SVOM instruments. Different notice examples are also included to illustrates the different notice subtypes.