Merge pull request #1282 from lpsinger/eslint-object-shorthand

Enable eslint object-shorthand rule
nasa-gcn · Aug 24, 2023 · 72f8ed0 · 72f8ed0
2 parents f6e982d + 90fae03
commit 72f8ed0
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 10 deletions.
diff --git a/app/root.tsx b/app/root.tsx
@@ -121,7 +121,7 @@ export const links: LinksFunction = () => [
   ...(cssBundleHref ? [{ rel: 'stylesheet', href: cssBundleHref }] : []),
   ...Object.entries(favicons).map(([size, href]) => ({
     rel: 'icon',
-    href: href,
+    href,
     sizes: `${size}x${size}`,
   })),
 ]

diff --git a/app/routes/circulars/circulars.server.ts b/app/routes/circulars/circulars.server.ts
@@ -45,7 +45,7 @@ export const getDynamoDBAutoIncrement = memoizee(
       counterTableName,
       counterTableKey: { tableName: 'circulars' },
       counterTableAttributeName: 'circularId',
-      tableName: tableName,
+      tableName,
       tableAttributeName: 'circularId',
       initialValue: 1,
       dangerously,

diff --git a/app/routes/user.email.edit.tsx b/app/routes/user.email.edit.tsx
@@ -57,7 +57,7 @@ export async function action({ request }: DataFunctionArgs) {
     name: name.toString(),
     recipient: recipient.toString(),
     created: 0,
-    topics: topics,
+    topics,
     uuid: uuid?.toString(),
     sub: user.sub,
   }

diff --git a/app/routes/user.endorsements/endorsements.server.ts b/app/routes/user.endorsements/endorsements.server.ts
@@ -117,7 +117,7 @@ export class EndorsementsServer {
     await db.circular_endorsements.update({
       Key: {
         requestorSub: this.#sub,
-        endorserSub: endorserSub,
+        endorserSub,
       },
       UpdateExpression:
         'set #status = :status, endorserEmail = :endorserEmail, requestorEmail = :requestorEmail, created = :created, note = :note',
@@ -187,7 +187,7 @@ export class EndorsementsServer {
 
     const requestorEmail: string = (
       await db.circular_endorsements.get({
-        requestorSub: requestorSub,
+        requestorSub,
         endorserSub: this.#sub,
       })
     )?.requestorEmail
@@ -199,7 +199,7 @@ export class EndorsementsServer {
 
     await db.circular_endorsements.update({
       Key: {
-        requestorSub: requestorSub,
+        requestorSub,
         endorserSub: this.#sub,
       },
       UpdateExpression: 'set #status = :status',
@@ -277,7 +277,7 @@ export class EndorsementsServer {
     const param = {
       Key: {
         requestorSub: this.#sub,
-        endorserSub: endorserSub,
+        endorserSub,
       },
       TableName: tableName,
       ConditionExpression: '#status = :pendingStatus',

diff --git a/package.json b/package.json
@@ -154,15 +154,14 @@
       "prettier"
     ],
     "rules": {
-      "no-implicit-coercion": [
-        "error"
-      ],
+      "no-implicit-coercion": "error",
       "no-restricted-globals": [
         "error",
         "event",
         "name",
         "origin"
       ],
+      "object-shorthand": "error",
       "prefer-const": "error"
     },
     "overrides": [