Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bookmarkable anchors to news items #1274

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

lpsinger
Copy link
Member

No description provided.

@lpsinger lpsinger requested review from Courey and dakota002 August 23, 2023 18:31
@lpsinger lpsinger added enhancement New feature or request frontend Issue relates to front-end development (react-uswds widgets) labels Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (ad79fa0) 5.57% compared to head (862e136) 5.56%.

❗ Current head 862e136 differs from pull request most recent head b7e3b07. Consider uploading reports for the commit b7e3b07 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1274      +/-   ##
========================================
- Coverage   5.57%   5.56%   -0.01%     
========================================
  Files         99     100       +1     
  Lines       2441    2445       +4     
  Branches     298     298              
========================================
  Hits         136     136              
- Misses      2303    2307       +4     
  Partials       2       2              
Files Changed Coverage Δ
app/components/Anchor.tsx 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lpsinger lpsinger changed the title News slug anchors Add bookmarkable anchors to news items Aug 23, 2023
remix.config.mjs Outdated Show resolved Hide resolved
@lpsinger lpsinger merged commit 089b9d1 into nasa-gcn:main Aug 23, 2023
@lpsinger lpsinger deleted the news-slug-anchors branch August 23, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Issue relates to front-end development (react-uswds widgets)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants