Circulars Sort Results by Relevance #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpsinger
requested changes
Jan 22, 2024
also renamed some of the sort variables
very very rough version of a UI button for selecting the sort method. defaults to sorting by circularID but can be changed to relevance. partial implementation of a sort order, but that needs to be implemented in the button.
|
I tried to do something similar to the date range filtering button, and the component is pretty similar as a result. I wanted to try to have it so there was a button to change the order of the results to be ascending instead of descending, but that isn't fully functional at the moment. Also need to figure out a better looking menu; I used the DetailsDropdownContent component, but I'm not entirely sure if that's the best option here; would be nice to try to figure out a way to use the Select component while still being able to have it appear as a standard button.
|
lpsinger
requested changes
Jan 24, 2024
There was a problem hiding this comment.
- Remove commented out code
- Use radio buttons instead of links
- Don't manually construct the query string; the values of the radio buttons will automatically be included in the form request on submission
- Let's not add support for selecting sort order right now; there's no reason to support sorting by decreasing relevance.
|
switched to radio buttons |
|
It occurs to me that it would be useful to have some sort of listener that automatically collapses any divs if the user clicks away from them to prevent menus from drawing over each other like this
|
lpsinger
requested changes
Jan 25, 2024
app/routes/_gcn.circulars._archive._index/SortSelectorButton.tsx
Outdated
Show resolved
Hide resolved
app/routes/_gcn.circulars._archive._index/SortSelectorButton.tsx
Outdated
Show resolved
Hide resolved
app/routes/_gcn.circulars._archive._index/SortSelectorButton.tsx
Outdated
Show resolved
Hide resolved
using same implementation as pr nasa-gcn#1856 to remove hard-coding of form id in route.tsx as well.
lpsinger
requested changes
Jan 29, 2024
app/routes/_gcn.circulars._archive._index/SortSelectorButton.tsx
Outdated
Show resolved
Hide resolved
app/routes/_gcn.circulars._archive._index/SortSelectorButton.tsx
Outdated
Show resolved
Hide resolved
app/routes/_gcn.circulars._archive._index/SortSelectorButton.tsx
Outdated
Show resolved
Hide resolved
app/routes/_gcn.circulars._archive._index/SortSelectorButton.tsx
Outdated
Show resolved
Hide resolved
app/routes/_gcn.circulars._archive._index/SortSelectorButton.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Leo Singer <[email protected]>
fix merge
lpsinger
requested changes
Jan 29, 2024
app/routes/_gcn.circulars._archive._index/SortSelectorButton.tsx
Outdated
Show resolved
Hide resolved
app/routes/_gcn.circulars._archive._index/SortSelectorButton.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Leo Singer <[email protected]>
accidentally removed when fixing merge conflict
lpsinger
requested changes
Feb 1, 2024
app/routes/_gcn.circulars._archive._index/SortSelectorButton.tsx
Outdated
Show resolved
Hide resolved
lpsinger
requested changes
Feb 1, 2024
app/routes/_gcn.circulars._archive._index/SortSelectorButton.tsx
Outdated
Show resolved
Hide resolved
lpsinger
requested changes
Feb 9, 2024
app/routes/_gcn.circulars._archive._index/SortSelectorButton.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Leo Singer <[email protected]>
made sortOptions keyed by value and then switched the way the mapping worked when generating the radio buttons as a result. Changed label for Circular ID option to date. backend still uses circularID, however
|
the failing check seems to be a network error? |
lpsinger
requested changes
Feb 13, 2024
app/routes/_gcn.circulars._archive._index/SortSelectorButton.tsx
Outdated
Show resolved
Hide resolved
app/routes/_gcn.circulars._archive._index/SortSelectorButton.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Leo Singer <[email protected]>
sort selection input is now sanitized such that the SortSelector function checks that the provided value in the url is a key of the sortOptions object. If it is not, the value defaults to sorting by the date.
lpsinger
approved these changes
Feb 14, 2024
jak574
pushed a commit
to swyatt7/gcn.nasa.gov
that referenced
this pull request
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, searching for circulars sorts by circular ID (ie newest to oldest), but it's also possible to sort by relevance; I'm unsure if it would be better to sort by relevance once we implement the NLP search functionality
Searching 'GRB' and sorting by ID:
Searching 'GRB' and sorting by relevance:
There's some balance to be made between showing the most relevant results and also weighting the most recent results, since they're arguably the circulars users are more likely to search for.
Another option would be to default to relevance and have the option to sort by circular ID if a toggle is set; this could be accomplished using the sortable tables, which I've been experimenting with in #1816