Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Markdown editing and rendering support for Circulars #1913

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

lpsinger
Copy link
Member

@lpsinger lpsinger commented Feb 9, 2024

This is currently hidden behind a feature flag until we have documentation and announcements for it.

Screenshot

Screenshot 2024-02-14 at 13 37 33

@lpsinger lpsinger added this to the Astro Flavored Markdown milestone Feb 9, 2024
@lpsinger lpsinger changed the title Add Markdown support for GCN Circulars Add Markdown editing and rendering support for Circulars Feb 14, 2024
@lpsinger lpsinger added enhancement New feature or request frontend Issue relates to front-end development (react-uswds widgets) backend Issue relates to back-end development (API endpoints and other server-side code) labels Feb 14, 2024
@Vidushi-GitHub
Copy link
Member

Cool feature!

I have two suggestions:
(a) The content box looks a bit cut off from the upside, because of that it appears a bit crowded.
(b) What about adding a save button? back, save and send?

@tylerbarna
Copy link
Member

It may be helpful to add a page to the documentation that explains what markdown is and the basic uses of it for circulars, something along the lines of this (but much more basic)

@lpsinger
Copy link
Member Author

(a) The content box looks a bit cut off from the upside, because of that it appears a bit crowded.

Fixed:

Screenshot 2024-02-14 at 14 42 27

(b) What about adding a save button? back, save and send?

Like, to save a draft? Interesting idea, but that would be a significant new feature.

@lpsinger lpsinger mentioned this pull request Feb 14, 2024
@lpsinger
Copy link
Member Author

It may be helpful to add a page to the documentation that explains what markdown is and the basic uses of it for circulars, something along the lines of this (but much more basic)

Definitely. I opened a separate issue for that: #1925.

This is currently hidden behind a feature flag until we have
documentation and announcements for it.
@lpsinger lpsinger merged commit d668026 into nasa-gcn:main Feb 16, 2024
6 checks passed
@lpsinger lpsinger deleted the circulars-markdown branch February 16, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Issue relates to back-end development (API endpoints and other server-side code) enhancement New feature or request frontend Issue relates to front-end development (react-uswds widgets)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants