Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTP migration docs #2607

Merged
merged 1 commit into from
Oct 29, 2024
Merged

VTP migration docs #2607

merged 1 commit into from
Oct 29, 2024

Conversation

jracusin
Copy link
Contributor

@jracusin jracusin commented Oct 4, 2024

Description

VTP migration plan options and seeking of user feedback.

Related Issue(s)

Issue #2608

Testing

@jracusin jracusin requested a review from lpsinger October 4, 2024 14:34
@jracusin jracusin self-assigned this Oct 4, 2024
@jracusin jracusin added the documentation Improvements or additions to documentation label Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.22%. Comparing base (26d96ca) to head (8779977).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2607   +/-   ##
=====================================
  Coverage   6.22%   6.22%           
=====================================
  Files        167     167           
  Lines       4225    4225           
  Branches     467     467           
=====================================
  Hits         263     263           
  Misses      3960    3960           
  Partials       2       2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

app/routes/docs.tsx Outdated Show resolved Hide resolved
app/routes/docs.vtp.md Outdated Show resolved Hide resolved
app/routes/docs.vtp.md Outdated Show resolved Hide resolved
app/routes/docs.vtp.md Outdated Show resolved Hide resolved
app/routes/docs.vtp.md Outdated Show resolved Hide resolved
@lpsinger
Copy link
Member

lpsinger commented Oct 8, 2024

Remember that we have some documentation on how we would do server-side programmable filtering with Comet in nasa-gcn/pygcn#48. See Markdown rendering of the docs.

@jracusin jracusin force-pushed the vtp-proposal branch 2 times, most recently from 9a7ba1f to 80598a1 Compare October 9, 2024 18:59
@jracusin
Copy link
Contributor Author

jracusin commented Oct 9, 2024

Screenshot of new table layout
Screenshot 2024-10-09 at 3 09 47 PM

Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this adequately explains why a transition of any kind is necessary.

app/routes/docs.vtp.mdx Outdated Show resolved Hide resolved
app/routes/docs.vtp.mdx Outdated Show resolved Hide resolved
app/routes/docs.vtp.mdx Outdated Show resolved Hide resolved
app/routes/docs.vtp.mdx Outdated Show resolved Hide resolved
app/routes/docs.vtp.mdx Outdated Show resolved Hide resolved
@jracusin jracusin force-pushed the vtp-proposal branch 2 times, most recently from 921f601 to 18033e1 Compare October 28, 2024 18:42
@jracusin
Copy link
Contributor Author

Screenshot 2024-10-28 at 3 55 31 PM

app/routes/docs.vtp.mdx Outdated Show resolved Hide resolved
@jracusin
Copy link
Contributor Author

Note that I had to prevent prettier from reformatting the Cards to keep the header height the same.

@jracusin
Copy link
Contributor Author

Rebased and put under feature flag

@jracusin jracusin merged commit 8186216 into nasa-gcn:main Oct 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants