Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds chime quickstart items and basic empty mission page behind feature flag #2702

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Adds chime quickstart items and basic empty mission page behind feature flag #2702

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3f7d006
Adds chime quickstart items and basic empty mission page
dakota002 Nov 6, 2024
9bb62f2
Update app/components/NoticeTypeCheckboxes/NoticeTypeCheckboxes.tsx
dakota002 Nov 12, 2024
6558bc2
Update app/routes/missions.chime/route.mdx
dakota002 Nov 12, 2024
5afdd25
Adds side nav link
dakota002 Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/components/NoticeTypeCheckboxes/NoticeTypeCheckboxes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,11 @@
JsonNoticeTypeLinks['Super Kamiokande'] = '/missions/sksn'
}

if (useFeature('CHIME')) {
JsonNoticeTypes.Chime = ['gcn.notices.chime.alert']
JsonNoticeTypeLinks.Chime = '/missions/chime'

Check warning on line 249 in app/components/NoticeTypeCheckboxes/NoticeTypeCheckboxes.tsx

View check run for this annotation

Codecov / codecov/patch

app/components/NoticeTypeCheckboxes/NoticeTypeCheckboxes.tsx#L248-L249 

Added lines #L248 - L249 were not covered by tests
}

const counterfunction = (childRef: HTMLInputElement) => {
if (childRef.checked) {
userSelected.add(childRef.name)
Expand Down
13 changes: 13 additions & 0 deletions app/routes/missions.chime/route.mdx
View file
Open in desktop
dakota002 marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
handle:
breadcrumb: Chime
---

import { feature } from '~/lib/env.server'

export async function loader() {
if (!feature('CHIME')) throw new Response(null, { status: 404 })
return null
}

# Chime
Loading