Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIME/FRB Mission Page #2714

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Conversation

Vidushi-GitHub
Copy link
Member

Description

PR for adding CHIME/FRB mission page over GCN website.

Related Issues

Please find how content looks like at website:
Screenshot 2024-11-12 at 2 44 46 PM

Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve merge conflicts.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.21%. Comparing base (ac0f2ba) to head (70f8b2d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2714   +/-   ##
=====================================
  Coverage   6.21%   6.21%           
=====================================
  Files        167     167           
  Lines       4235    4235           
  Branches     468     468           
=====================================
  Hits         263     263           
  Misses      3970    3970           
  Partials       2       2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vidushi-GitHub
Copy link
Member Author

https://github.com/tabbott36 Please provide your feedback.

Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a point of contact from CHIME that we can add as a reviewer?

app/routes/missions.chime/route.mdx Outdated Show resolved Hide resolved
app/routes/missions.chime/route.mdx Outdated Show resolved Hide resolved
app/routes/missions.chime/route.mdx Outdated Show resolved Hide resolved
app/routes/missions.chime/route.mdx Outdated Show resolved Hide resolved
app/routes/missions.chime/route.mdx Outdated Show resolved Hide resolved
app/routes/missions.chime/route.mdx Outdated Show resolved Hide resolved
app/routes/missions.chime/route.mdx Show resolved Hide resolved
app/routes/missions.tsx Outdated Show resolved Hide resolved
app/routes/missions.chime/route.mdx Show resolved Hide resolved
@Vidushi-GitHub
Copy link
Member Author

Do we have a point of contact from CHIME that we can add as a reviewer?

Kindly add https://github.com/tabbott36 as a reviewer, I am unable to add.

@lpsinger
Copy link
Member

Do we have a point of contact from CHIME that we can add as a reviewer?

Kindly add https://github.com/tabbott36 as a reviewer, I am unable to add.

@tabbott36, we sent you an invitation to join our GitHub org. Would you please accept it?

@tabbott36
Copy link

This looks great to me!

@lpsinger lpsinger merged commit 67d176c into nasa-gcn:main Nov 14, 2024
12 checks passed
@Vidushi-GitHub Vidushi-GitHub deleted the missionpage/chime branch November 15, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants