Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flake8 directly instead of through pytest-flake8 #36

Merged
merged 2 commits into from
Apr 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,15 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
pip install pytest-flake8 pytest-cov
pip install flake8 pytest-cov
- name: Lint
run: |
flake8 .
- name: Build
run: |
pip install -e .
- name: Test
run: |
pytest --flake8 --cov --cov-report=xml
pytest --cov --cov-report=xml
- name: Upload coverage to codecov
uses: codecov/codecov-action@v3
6 changes: 3 additions & 3 deletions gcn/voeventclient.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,9 @@ def _form_response(role, origin, response, timestamp):


def _ingest_packet(sock, ivorn, handler, log):
"""Ingest one VOEvent Transport Protocol packet and act on it, first sending
the appropriate response and then calling the handler if the payload is a
VOEvent."""
"""Ingest one VOEvent Transport Protocol packet and act on it, first
sending the appropriate response and then calling the handler if the
payload is a VOEvent."""
# Receive payload
payload = _recv_packet(sock)
log.debug("received packet of %d bytes", len(payload))
Expand Down