Fixed issues with mrf chopping and moving #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jackiryan
commented
Aug 28, 2024
jackiryan
commented
- Fixed various indexing bugs associated with mrf_insert
- Before merging, I still need to conduct functional tests across a variety of data types and layers that we currently produce, such as PREFIRE, corrected reflectance, and others.
jtroberts
approved these changes
Sep 25, 2024
| << "In " << in_img.bbox << endl; | ||
| } | ||
|
|
||
| // Tolerance of 1/2 of an output pixel |
There was a problem hiding this comment.
What does this tolerance refer to?
| CPLError(CE_Failure, CPLE_AppDefined, "Input patch outside of target"); | ||
| throw 2; | ||
| } | ||
|
|
||
| // Get the first band, which always exists, use it to collect some info | ||
| // tolerance of 1/1000 of the resolution |
There was a problem hiding this comment.
And what does this tolerance refer to?
There was a problem hiding this comment.
This tolerance is the tolerance used to determine if the edge of a granule should disqualify it from inclusion in an MRF. The tolerance was too tight previously, slight reprojection or downsampling changes could cause an entire row of data to be excluded for extending to, for example, 90.01 degrees latitude.
|
Merging this PR with "failing" unit tests in the onearth repository as our investigation has determined that the raster discrepancies are acceptable and expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.