Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WV-3265 Point Sizing for MODIS_Aqua_Thermal_Anomalies_All #5646

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

christof-wittreich
Copy link
Contributor

Description

This change adds point sizing for the MODIS_Aqua_Thermal_Anomalies_All layer. Point sizes are 1 (default), 5, 10, 15, 20, and 25. The points change in size based on the selection, when zoomed both in and out on the layer.

How To Test

  1. git checkout wv-3265-eic-fires-bigpoint
  2. Change line 4 in config/default/release/config.json from ...https://gibs.earthdata.nasa.gov... to ...https://uat.gibs.earthdata.nasa.gov..., since the change only exists currently in UAT.
  3. npm run build
  4. npm ci
  5. npm run watch
  6. Open a fresh instance of Worldview
  7. Add the MODIS_Aqua_Thermal_Anomalies_All layer and verify it looks correct normally before changing any sizing
  8. Open the layer options window for this layer and drag the Point Size slider to change the point size
  9. Verify the point size for this layer updates appropriately both when zoomed out and when zoomed in close
  10. Verify that all point sizes work correctly and the layer otherwise works as normal
  11. Verify that the page can be reloaded and the sizing information is retained properly
  12. Verify that these changes do not break other vector layers in any way

@Tomcariello
Copy link
Contributor

Tomcariello commented Jan 10, 2025

This looks good! The only thing I noticed was when attempting to take a snapshot after increasing the point size WV detects changes & asks to revert to default settings. However, the point size is not reverted when you click OK.

@minniewong minniewong added this to the v4.56.0 milestone Jan 10, 2025
Copy link
Contributor

@minniewong minniewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I like the slider :) I wasn't able to change the color of the points, should I be able to?

@christof-wittreich
Copy link
Contributor Author

@minniewong You should be able to change the point color as normal, yes. I am able to do this on my end, so if you're not able to, I would like to be able to replicate that issue

@christof-wittreich
Copy link
Contributor Author

@Tomcariello I have fixed the point sizing interaction with the snapshot feature now

@Tomcariello
Copy link
Contributor

Found another bug:

  • Load the MODIS_Aqua_Thermal_Anomalies_All layer
  • Change the point size to anything greater than 1.
  • Change the color to anything other than Default.
  • Change the point size back to 1.
  • Notice the point color reverts back to default.

@Tomcariello
Copy link
Contributor

@Tomcariello I have fixed the point sizing interaction with the snapshot feature now

This looks good now!

@christof-wittreich
Copy link
Contributor Author

@Tomcariello I have just pushed a fix that addresses custom point colors unsetting when size is reset to 1

@minniewong minniewong self-requested a review January 21, 2025 21:43
Copy link
Contributor

@minniewong minniewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants