-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WV-3265 Point Sizing for MODIS_Aqua_Thermal_Anomalies_All #5646
base: develop
Are you sure you want to change the base?
Conversation
This looks good! The only thing I noticed was when attempting to take a snapshot after increasing the point size WV detects changes & asks to revert to default settings. However, the point size is not reverted when you click OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I like the slider :) I wasn't able to change the color of the points, should I be able to?
@minniewong You should be able to change the point color as normal, yes. I am able to do this on my end, so if you're not able to, I would like to be able to replicate that issue |
@Tomcariello I have fixed the point sizing interaction with the snapshot feature now |
Found another bug:
|
This looks good now! |
@Tomcariello I have just pushed a fix that addresses custom point colors unsetting when size is reset to 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Description
This change adds point sizing for the
MODIS_Aqua_Thermal_Anomalies_All
layer. Point sizes are 1 (default), 5, 10, 15, 20, and 25. The points change in size based on the selection, when zoomed both in and out on the layer.How To Test
git checkout wv-3265-eic-fires-bigpoint
config/default/release/config.json
from...https://gibs.earthdata.nasa.gov...
to...https://uat.gibs.earthdata.nasa.gov...
, since the change only exists currently in UAT.npm run build
npm ci
npm run watch
MODIS_Aqua_Thermal_Anomalies_All
layer and verify it looks correct normally before changing any sizing