-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add lerc decoder #5685
base: develop
Are you sure you want to change the base?
Feature/add lerc decoder #5685
Conversation
@@ -56,6 +56,7 @@ | |||
"VIIRS_NOAA21_CorrectedReflectance_TrueColor", | |||
"VIIRS_NOAA21_CorrectedReflectance_BandsM3-I3-M11", | |||
"VIIRS_NOAA21_CorrectedReflectance_BandsM11-I2-I1", | |||
"VIIRS_VNP46A1_LERC_v1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should rename this layer to maybe VIIRS_SNPP_DayNightBand_LERC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree and I will change once we ingest more data under that ID since the ID here is used for the imagery requests
I updated the add more imagery ticket to include this new ID
NOTE THAT THIS IS STILL A WIP: I need to add LERC to the endpoints so it doesn't need to be hard coded in but I am not sure what the worldview standard process is for adding a layer
Right now, I am accessing the lerc layers by running Joe's ec2 instance and using localhost, so we need to publish the lerc layers and also add more than 1 day of data
Once the LERC layer is added to the official endpoints, we can get the snapshot that matches the rest of the snapshots by running
npm run build
which gets the snapshot with a request to https://wvs.earthdata.nasa.gov/api/v1/snapshotI am keeping the incorrect
web/images/layers/previews/geographic/VIIRS_VNP46A1_LERC_v1.jpg
in this PR as a reminder for nowI also still need to create tests that the LERC layers are showing up properly
Description
Adds the LERC decoder to worldview so that LERC layers are now supported. Some other notes:
drawTile
was for comparing the average/ difference between 2 layers. The closest feature in worldview was comparison mode which is just displaying 2 layers normally but side by sideWe agreed this was okay in a meeting 2/4/2025
drawTile
(which is the case if the user altered the layer thresholds), then don’t show values above or below the current thresholdThings discussed but were resolved:
[Description of the bug or feature]
[If this is a relatively large or complex change, start a discussion by explaining why you chose the solution you did and what alternatives you considered, etc...]
Potential discussion topics in bullets above
How To Test
[Provide whatever information a reviewer might need to know in order to verify that the changes made in this PR are working as expected. If there are special build steps that need to be taken in order to get these changes to run (building while on a separate branch, running
npm ci
, etc) include them here.]Can now open VIIRS Nighttime Imagery LERC layer to the map and view it. This LERC layer should have all functionality like changing the palette, min/max values, and opacity. All other layers and behavior should function the same
I verified that I could delete my local copy of worldview and rebuild/ run
PR Submission Checklist
This is simply a reminder of what we are going to look for before merging your code.
Merging
Please use the
squash and merge
commit method unless each commit in your branch is vital to the commit history of main.@nasa-gibs/worldview