Fix toolbar modal positioning #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change `left` position direction to `right` as per documentation - Import `jquery-ui/position` to wvui to prevent unexpected results
ghost
assigned 
|
This is the issue I was seeing after #503 changes:
|
localjo
approved these changes
Jan 22, 2018
| @@ -1,6 +1,7 @@ | |||
| import $ from 'jquery'; | |||
| import 'jquery-ui/dialog'; | |||
| import 'jquery-ui/menu'; | |||
| import 'jquery-ui/position'; | |||
There was a problem hiding this comment.
This adds 15.5k to the bundle. I think that's ok.
Benjaki2
approved these changes
Jan 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request:
leftposition direction torightas per documentationjquery-ui/positionto wvui to prevent unexpected results