Merge pull request #267 from skliper/fix215-improve_coverage

Fix #194 #108 #215 #27 #266, Coverage improvements
nasa · Jun 22, 2022 · bff67f8 · bff67f8
2 parents 1ba450b + 022c496
commit bff67f8
Show file tree

Hide file tree

Showing 16 changed files with 320 additions and 2,149 deletions.
diff --git a/.github/workflows/unit-test-coverage.yml b/.github/workflows/unit-test-coverage.yml
@@ -8,6 +8,3 @@ jobs:
   unit-test-coverage:
     name: Run unit test and coverage
     uses: nasa/cFS/.github/workflows/unit-test-coverage.yml@main
-    with:
-      max-missed-branches: 8
-      max-missed-lines: 2
diff --git a/fsw/src/cf_clist.c b/fsw/src/cf_clist.c
@@ -142,7 +142,7 @@ void CF_CList_Remove(CF_CListNode_t **head, CF_CListNode_t *node)
     CF_Assert(node);
     CF_Assert(*head);
 
-    if ((node->next == node) && (node->prev == node))
+    if (node->next == node)
     {
         /* only node in the list, so this one is easy */
         CF_Assert(node == *head); /* sanity check */

diff --git a/fsw/src/cf_utils.c b/fsw/src/cf_utils.c
@@ -201,6 +201,7 @@ int CF_WriteHistoryEntryToFile(osal_id_t fd, const CF_History_t *h)
                 snprintf(linebuf, sizeof(linebuf), "SRC: %s\t", h->fnames.src_filename);
                 break;
             case 2:
+            default:
                 snprintf(linebuf, sizeof(linebuf), "DST: %s\n", h->fnames.dst_filename);
                 break;
         }

diff --git a/unit-test/CMakeLists.txt b/unit-test/CMakeLists.txt
@@ -37,7 +37,6 @@
 add_cfe_coverage_stubs(cf_internal
   utilities/cf_test_utils.c
   utilities/cf_test_alt_handler.c
-  utilities/ut_utils_cfe_hooks.c
 
   stubs/cf_app_global.c
   stubs/cf_app_stubs.c