Fix #390, Update size variables to size_t and CF_ChunkSize_t typedefs
#391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thnkslprpt
force-pushed
the
fix-390-update-size-variables-to-typedefs
branch
from
95ac14c
to
beaf93b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
thnkslprpt
force-pushed
the
fix-390-update-size-variables-to-typedefs
branch
from
beaf93b
to
4068927
Compare
fsw/src/cf_crc.c
Outdated
| @@ -50,9 +50,9 @@ | |||
| * See description in cf_crc.h for argument/return detail | |||
| * | |||
| *-----------------------------------------------------------------*/ | |||
| void CF_CRC_Digest(CF_Crc_t *c, const uint8 *data, int len) | |||
| void CF_CRC_Digest(CF_Crc_t *c, const uint8 *data, size_t len) | |||
Check notice
Code scanning / CodeQL
Long function without assertion
thnkslprpt
force-pushed
the
fix-390-update-size-variables-to-typedefs
branch
from
4068927
to
13bfde8
Compare
jphickey
requested changes
Dec 13, 2023
thnkslprpt
force-pushed
the
fix-390-update-size-variables-to-typedefs
branch
from
13bfde8
to
602fe52
Compare
| @@ -941,7 +941,7 @@ | |||
| struct | |||
| { | |||
| void * ptr; | |||
| uint32 size; | |||
| size_t size; | |||
Check notice
Code scanning / CodeQL
Function too long Note
| @@ -941,7 +941,7 @@ | |||
| struct | |||
| { | |||
| void * ptr; | |||
| uint32 size; | |||
| size_t size; | |||
Check notice
Code scanning / CodeQL
Long function without assertion Note
| @@ -50,9 +50,9 @@ | |||
| * See description in cf_crc.h for argument/return detail | |||
| * | |||
| *-----------------------------------------------------------------*/ | |||
| void CF_CRC_Digest(CF_Crc_t *crc, const uint8 *data, int len) | |||
| void CF_CRC_Digest(CF_Crc_t *crc, const uint8 *data, size_t len) | |||
Check notice
Code scanning / CodeQL
Long function without assertion Note
thnkslprpt
force-pushed
the
fix-390-update-size-variables-to-typedefs
branch
from
602fe52
to
5f768d4
Compare
jphickey
added
the
CCB:Ready
dzbaker
added
CCB:Approved
and removed
CCB:Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
size_torCF_ChunkSize_t#390Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Expected behavior changes
No change to behavior.
Contributor Info
Avi Weiss @thnkslprpt