Fix #424, Add EDS #425
Merged
Fix #424, Add EDS #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Submitted as a draft due to dependencies that are not yet merged to main |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL-coding-standard found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
jphickey
force-pushed
the
fix-424-add-eds
branch
3 times, most recently
from
3e425da
to
209dcfc
Compare
Add an EDS XML file for CF, along with alternate dispatcher to route messages based on EDS.
jphickey
force-pushed
the
fix-424-add-eds
branch
from
209dcfc
to
a18ec4d
Compare
|
Rebased now that dependencies have been merged. |
|
Commit 72bda01 renames the mismatched argument name (static analysis reported issue) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Initial integration of the EDS file for CF app
Fixes #424
Testing performed
Build and run BP+CF with EDS framework, test file transfer
Expected behavior changes
An authoritative and concise CMD/TLM definition is available
System(s) tested on
Debian
Additional context
CF still builds and runs without EDS integration, if so desired.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.