Fix #430, correct type mismatches #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correction for various type mismatches across CF. Notably, many iterators do not use the CFE_Status_t return type, it should be a custom enum.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL-coding-standard found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
jphickey
added
the
CCB:Ready
dzbaker
added
CCB:Approved
and removed
CCB:Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Correction for various type mismatches across CF.
Notably, many iterators do not use the CFE_Status_t return type, it should be a custom enum.
Fixes #430
Testing performed
Build and run all tests
Run BP/DTN sanity check (uses CF to transfer file)
Expected behavior changes
Builds and runs on strict type-checking platforms
System(s) tested on
Debian with RTEMS 4.11 toolchain
Additional context
This may have been recently complicated as some return codes were changed to
CFE_Status_tthat should have remained as an integer (e.g. cases where it was a count or not one of the CFE error codes)Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.