Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft - CMR-10139: Updated code to remove subscription information from redis cache upon subscription delete. Updated schema to allow multiple modes. #2179

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eereiter
Copy link
Contributor

@eereiter eereiter commented Oct 1, 2024

Overview

What is the feature/fix?

Updated code to remove subscription information from redis cache upon subscription delete. Updated schema to allow multiple modes. Adding subscription to redis cache already in the code.

What is the Solution?

Updated code to remove subscription information from redis cache upon subscription delete. Updated schema to allow multiple modes.

What areas of the application does this impact?

Metadata_db

Checklist

  • I have updated/added unit and int tests that prove my fix is effective or that my feature works - in previous commit
  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors corrected
  • I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@eereiter eereiter changed the title Cmr 10139: Updated code to remove subscription information from redis cache upon subscription delete. Updated schema to allow multiple modes. Draft - CMR-10139: Updated code to remove subscription information from redis cache upon subscription delete. Updated schema to allow multiple modes. Oct 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 5.26316% with 18 lines in your changes missing coverage. Please review.

Project coverage is 58.16%. Comparing base (53f7115) to head (92f689c).

Files with missing lines Patch % Lines
...p/src/cmr/metadata_db/services/concept_service.clj 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2179      +/-   ##
==========================================
- Coverage   58.18%   58.16%   -0.03%     
==========================================
  Files        1047     1047              
  Lines       70480    70492      +12     
  Branches     2004     2002       -2     
==========================================
- Hits        41008    41000       -8     
- Misses      27608    27624      +16     
- Partials     1864     1868       +4     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants