Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #379, Align mismatched function prototype/implem. parameter names #380

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Feb 24, 2023

Checklist

Describe the contribution

All flight code function declarations now match the implementations (incl. parameter names).

Testing performed
GitHub CI actions all passing successfully.
Local test build - 100% tests passing successfully.

Expected behavior changes
No change to behavior.
Code clarity and consistency improved.

System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS.

Contributor Info
Avi Weiss @thnkslprpt

**
** Return:
** (none)
*/

void CFE_PSP_Restart(uint32 reset_type)
void CFE_PSP_Restart(uint32 resetType)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
@skliper
Copy link
Contributor

skliper commented Dec 13, 2023

This will need rebase and likely minor conflict resolution once #381 is in. Planning to review once those updates can be made.

@thnkslprpt thnkslprpt force-pushed the fix-379-mismatched-function-prototype-parameter-names branch from 6cde7b4 to 7e9108a Compare December 16, 2023 06:36
@thnkslprpt
Copy link
Contributor Author

This will need rebase and likely minor conflict resolution once #381 is in. Planning to review once those updates can be made.

@skliper - all done now mate.

@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Dec 18, 2023
@skliper
Copy link
Contributor

skliper commented Dec 18, 2023

@dzbaker @dmknutsen - Recommending for CCB review, thx!

@dzbaker dzbaker added CCB:Approved Indicates Approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jan 4, 2024
dzbaker added a commit to nasa/cFS that referenced this pull request Jan 5, 2024
*Combines:*

sch_lab v2.5.0-rc4+dev83
osal v6.0.0-rc4+dev251
PSP v1.6.0-rc4+dev115

**Includes:**

*cFS*
- #725

*sch_lab*
- nasa/sch_lab#164
- nasa/sch_lab#163

*osal*
- nasa/osal#1438

*PSP*
- nasa/PSP#380

Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Avi Weiss <[email protected]>
Co-authored by: Jacob Hageman <[email protected]>
@dzbaker dzbaker mentioned this pull request Jan 5, 2024
2 tasks
dzbaker added a commit to nasa/cFS that referenced this pull request Jan 8, 2024
*Combines:*

sch_lab v2.5.0-rc4+dev83
osal v6.0.0-rc4+dev251
PSP v1.6.0-rc4+dev115

**Includes:**

*cFS*
- #725

*sch_lab*
- nasa/sch_lab#164
- nasa/sch_lab#163

*osal*
- nasa/osal#1438

*PSP*
- nasa/PSP#380

Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Avi Weiss <[email protected]>
Co-authored by: Jacob Hageman <[email protected]>
dzbaker added a commit to nasa/cFS that referenced this pull request Jan 10, 2024
*Combines:*

sch_lab v2.5.0-rc4+dev83
osal v6.0.0-rc4+dev251
PSP v1.6.0-rc4+dev115

**Includes:**

*cFS*
- #725

*sch_lab*
- nasa/sch_lab#164
- nasa/sch_lab#163

*osal*
- nasa/osal#1438

*PSP*
- nasa/PSP#380

Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Avi Weiss <[email protected]>
Co-authored by: Jacob Hageman <[email protected]>
@dzbaker dzbaker merged commit cb38cdc into nasa:main Jan 10, 2024
11 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Jan 10, 2024
*Combines:*

sch_lab v2.5.0-rc4+dev83
osal v6.0.0-rc4+dev251
PSP v1.6.0-rc4+dev115

**Includes:**

*cFS*
- #725

*sch_lab*
- nasa/sch_lab#164
- nasa/sch_lab#163

*osal*
- nasa/osal#1438

*PSP*
- nasa/PSP#380

Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Avi Weiss <[email protected]>
Co-authored by: Jacob Hageman <[email protected]>
@thnkslprpt thnkslprpt deleted the fix-379-mismatched-function-prototype-parameter-names branch January 10, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates Approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrub for mismatched function prototype/implementation parameter names
4 participants