Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #243, #247, specification of remote IP address in bpcat #251

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

jphickey
Copy link
Collaborator

Describe the contribution
This fixes two issues that were observed during interoperability testing:

  • the remote UDP/IP address needs to be configurable at runtime
  • need to use sendto rather than connect + send because the returning traffic may not be from the same port number.

Fixes #243
Fixes #247

Testing performed
Interoperability testing

Expected behavior changes
UDP traffic flows between nodes as expected

System(s) tested on
RHEL 8 test systems

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Adds command line options for local and remote CLA IP address and port
numbers.
Update bpcat to use "sendto" to transmit to the for the remote node,
as opposed to connecting the socket.

This permits return traffic to come from any IP+port, not isolated to
the remote address that the socket was onnected to.
@jphickey jphickey added the ccb:ready Pull request is ready for CCB discussion label Sep 20, 2023
@jphickey jphickey added ccb:approved Pull request has been granted final approval for merging. All required process objectives are met. and removed ccb:ready Pull request is ready for CCB discussion labels Sep 27, 2023
@jphickey
Copy link
Collaborator Author

Reviewed and approved at 2023-09-27 CCB

@jphickey jphickey merged commit 35d6a72 into nasa:main Sep 27, 2023
8 checks passed
@jphickey jphickey deleted the fix-243-247 branch November 14, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ccb:approved Pull request has been granted final approval for merging. All required process objectives are met.
Projects
None yet
2 participants