Fix #246, recognize dtn:none special endpoint ID #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
force-pushed
the
fix-246-dtn-none-id
branch
from
b517ccc
to
59dbd03
Compare
This uses the DTN encoding scheme as opposed to IPN, but has a single integer value of 0 as the SSP. This construct should be recognized by the codec routines.
jphickey
force-pushed
the
fix-246-dtn-none-id
branch
from
59dbd03
to
2e44494
Compare
glan6388
approved these changes
Sep 25, 2023
jphickey
added
ccb:approved
|
Reviewed and approved at 2023-09-27 CCB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
This uses the DTN encoding scheme as opposed to IPN, but has a single integer value of 0 as the SSP. This construct should be recognized by the codec routines.
Fixes #246
Testing performed
This PR includes a sample CBOR-encoded bundle using dtn:none as part of sanity test
Expected behavior changes
Correctly recognizes and decodes this endpoint ID.
System(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.