Fix #252, propagate error code after decode failure #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "bplib_generic_bundle_ingress()" function was not correctly propagating an error status from the underlying decode operation. It was logging the error but using the return value from the bplog macro, which will be BP_SUCCESS. This also updates the coverage tests to use "INT32_EQ" rather than "UINT32_EQ", as the return value from these API calls is a signed integer.
glan6388
approved these changes
Sep 25, 2023
jphickey
added
ccb:approved
|
Reviewed and approved at 2023-09-27 CCB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
The "bplib_generic_bundle_ingress()" function was not correctly propagating an error status from the underlying decode operation. It was logging the error but using the return value from the bplog macro, which will be BP_SUCCESS.
This also updates the coverage tests to use "INT32_EQ" rather than "UINT32_EQ", as the return value from these API calls is a signed integer.
Fixes #252
Testing performed
Unit test cases updated to cover this case
Pass in bundle using unsupported features
Expected behavior changes
The
bplib_cla_ingress()function will returnBP_ERRORif the bundle being passed in does not decode successfullySystem(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.