-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON Dictionary Integration #173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, let us be clear, this is top-rate work. It is also an implementation of a fairly critical subsystem. Thus I made a lot of comments. There is one thing I'd like you to think about: Error checking and resolution.
I want there to be a clear story on what happens and what is returned on malformed JSON data. Given what I see, it is probably a ValueError, or a custom MalformedDictionary error, or a combination. All other errors should be down-converted to a known set of expressive errors.
This will help a lot in determining what to do in the layer above and avoid the random exception problem.
Let me know if you have questions.
Change Description
Implements nasa/fprime#2592