Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to ZMQ with --no-zmq to fallback on TTS #174

Merged
merged 3 commits into from
May 6, 2024

Conversation

thomas-bc
Copy link
Collaborator

Related Issue(s) nasa/fprime#2520
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

Defaults to using the ZMQ transport layer, falling back to TTS by user request with --no-zmq

Rationale

nasa/fprime#2520

@thomas-bc thomas-bc requested a review from LeStarch May 1, 2024 01:12
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must clean-up some ugly error handling. Note: I probably introduced the raise unintentionally.

Apart from that there is on broad-stroke to consider: this now requires zmq as a package, which is a different disposition than "use zmq if installed". It is likely advisable to to make this change, to simplify our support-space, but I want a moment to think through this while the other issue is touched-up.

src/fprime_gds/executables/cli.py Show resolved Hide resolved
@LeStarch LeStarch merged commit f983bb6 into nasa:devel May 6, 2024
11 checks passed
@thomas-bc thomas-bc deleted the default-to-zmq branch May 6, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants