IP-244 - Update actions/upload-artifacts to v4 due to v3 deprecation. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Same as for
earthdata-varinfo)I received a deprecation notice for one of the actions we use to upload artefacts during our CI/CD runs (coverage reports and JUnit style test results output).
For more information see here.
I don't think there are any breaking changes as we only use very basic options for the action and use unique names for each artefact we upload.
Jira Issue ID
N/A
Local Test Steps
N/A - just check there were artefacts saved to the workflow run for this PR. (See here - I'm only seeing one artefact. But I think that's something to do with the Swath Projector specifically. It has some weird logging etc for tests that we should probably rip out at some point to simplify things.)
PR Acceptance Checklist
All are non-applicable. These changes are internal to our CI/CD workflows and will not require a release of any service code.
Jira ticket acceptance criteria met.CHANGELOG.mdupdated to include high level summary of PR changes.docker/service_version.txtupdated if publishing a release.Tests added/updated and passing.Documentation updated (if needed).