Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ogma-cli: Add version bounds to base. Refs #180. #181

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

ivanperez-keera
Copy link
Member

Add version bounds to base in all components in the cabal package description of ogma-cli, as prescribed in the solution proposed for #180.

The cabal file for ogma-cli does not specify version bounds on base,
which makes hackage reject the package.

This commit adds version bounds to base in all components in the cabal
package description.
@ivanperez-keera
Copy link
Member Author

Change Manager: Verified that:

  • Solution is implemented:
    • The code proposed compiles and passes all tests. Details:
    • The solution proposed produces the expected result. Details:
      The following dockerfile checks that there is no reference to base in ogma-cli's cabal file that doesn't have version bounds, after which it prints the message "Success":
      FROM ubuntu:focal
      
      RUN apt-get update
      
      RUN apt-get install --yes git
      
      SHELL ["/bin/bash", "-c"]
      CMD git clone $REPO \
          && cd $NAME \
          && git checkout $COMMIT \
          && ! grep -niHre 'base$' ogma-cli/ogma-cli.cabal \
          && echo "Success"
      Command (substitute variables based on new path after merge):
      $ docker run -e "REPO=https://github.com/ivanperez-keera/ogma" -e "NAME=ogma" -e "PAT=ogma"  -e "COMMIT=a94046e26dc97cb91d92547b4754fe6f27d14568" -it ogma-verify-180
      
  • Implementation is documented. Details:
    No updates needed.
  • Change history is clear.
  • Commit messages are clear.
  • Changelogs are updated.
  • Examples are updated. Details:
    No updates needed; change is to cabal file.
  • Required version bumps are evaluated. Details:
    No bump needed; change doesn't affect compatibility of ogma with any versions of base.

@ivanperez-keera ivanperez-keera merged commit 3836380 into nasa:develop Nov 22, 2024
2 checks passed
@ivanperez-keera ivanperez-keera deleted the develop-cli-base branch November 23, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant