Skip to content

Commit

Permalink
Closes #7936
Browse files Browse the repository at this point in the history
- Remove `element-handle`.
  • Loading branch information
charlesh88 committed Dec 17, 2024
1 parent f4ec532 commit 49a106b
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions src/plugins/events/components/EventTimelineView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ export default {
},
plotEvents(item, containerElement) {
const existingEventWrapper = this.getEventWrapper(item);
// eventWrapper wraps the vertical tick and the EVENT
// eventWrapper IS NOW the vertical tick and the EVENT
if (existingEventWrapper) {
this.updateExistingEventWrapper(existingEventWrapper, item);
} else {
Expand Down Expand Up @@ -420,19 +420,16 @@ export default {
eventWrapper.setAttribute('id', id);
eventWrapper.classList.add(EVENT_WRAPPER_CLASS);
eventWrapper.style.left = `${this.xScale(event.time)}px`;
const eventTickElement = document.createElement('div');
eventTickElement.classList.add('c-events-tsv__event-handle');
if (this.titleKey) {
const textToShow = event[this.titleKey];
eventWrapper.ariaLabel = textToShow;
eventWrapper.addEventListener('mouseover', () => {
this.showToolTip(textToShow, eventTickElement);
this.showToolTip(textToShow, eventWrapper);
});
eventWrapper.addEventListener('mouseleave', () => {
this.tooltip?.destroy();
});
}
eventWrapper.appendChild(eventTickElement);
const limitEvaluation = this.limitEvaluator.evaluate(event, this.valueMetadata);
const limitClass = limitEvaluation?.cssClass;
if (limitClass) {
Expand All @@ -443,7 +440,7 @@ export default {
eventWrapper.addEventListener('click', (mouseEvent) => {
mouseEvent.stopPropagation();
this.createSelectionForInspector(event);
this.toggleEventSelection(eventTickElement);
this.toggleEventSelection(eventWrapper);
this.extendedLinesBus.eventClicked(this.keyString);
});

Expand Down

0 comments on commit 49a106b

Please sign in to comment.