Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Update to Node 20 and remove 16 (EOL) #7260

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[Build] Update to Node 20 and remove 16 (EOL) #7260

merged 1 commit into from
Nov 28, 2023

Conversation

unlikelyzero
Copy link
Contributor

@unlikelyzero unlikelyzero commented Nov 28, 2023

Closes: #6732

Describe your changes:

Adds node20 to our support matrix
Removes node16 from our support matrix (EOL last september)
Ensures node 18 is the default (per @akhenry )

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@unlikelyzero unlikelyzero added dependencies Pull requests that update a dependency file type:maintenance tests, chores, or project maintenance pr:platform Runs tests against all supported platforms pr:e2e:couchdb npm run test:e2e:couchdb labels Nov 28, 2023
@unlikelyzero unlikelyzero added this to the Target:3.3.0 milestone Nov 28, 2023
@unlikelyzero unlikelyzero requested review from akhenry and ozyx November 28, 2023 15:52
@unlikelyzero unlikelyzero changed the title [Build] Update to Node 20 [Build] Update to Node 20 and remove 16 (EOL) Nov 28, 2023
@github-actions github-actions bot removed the pr:platform Runs tests against all supported platforms label Nov 28, 2023
Copy link

deploysentinel bot commented Nov 28, 2023

Current Playwright Test Results Summary

✅ 14 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/28/2023 04:05:30pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 1925997

Started: 11/28/2023 03:58:41pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1Initial Attempt
0% (0) 0 / 24 runs
failed over last 7 days
16.67% (4) 4 / 24 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 162 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/28/2023 04:05:30pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 1925997

Started: 11/28/2023 03:55:25pm UTC

⚠️ Flakes

📄   functional/plugins/timer/timer.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Timer Can perform actions on the Timer
Retry 1Initial Attempt
0% (0) 0 / 18 runs
failed over last 7 days
22.22% (4) 4 / 18 runs
flaked over last 7 days

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
0% (0) 0 / 18 runs
failed over last 7 days
16.67% (3) 3 / 18 runs
flaked over last 7 days

View Detailed Build Results


@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #7260 (1925997) into master (28bfc90) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7260      +/-   ##
==========================================
- Coverage   56.07%   56.06%   -0.01%     
==========================================
  Files         654      654              
  Lines       26228    26228              
  Branches     2528     2528              
==========================================
- Hits        14707    14706       -1     
+ Misses      10825    10823       -2     
- Partials      696      699       +3     
Flag Coverage Δ
e2e-full 41.92% <ø> (ø)
e2e-stable 58.35% <ø> (+0.01%) ⬆️
unit 49.35% <ø> (-0.02%) ⬇️

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28bfc90...1925997. Read the comment docs.

package.json Show resolved Hide resolved
@@ -22,7 +22,7 @@ jobs:
- macos-latest
- windows-latest
node_version:
- lts/gallium
- lts/iron
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a tip is also to change the .nvmrc file to lts/iron

@unlikelyzero unlikelyzero merged commit 39a3161 into master Nov 28, 2023
49 of 54 checks passed
@unlikelyzero unlikelyzero deleted the node20 branch November 28, 2023 21:05
@skrobchik skrobchik mentioned this pull request Nov 30, 2023
15 tasks
@unlikelyzero unlikelyzero modified the milestones: Target:3.3.0, Target:4.0.0 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node 20 Support
3 participants