-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Update to Node 20 and remove 16 (EOL) #7260
Conversation
Current Playwright Test Results Summary✅ 14 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/28/2023 04:05:30pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 1925997 Started: 11/28/2023 03:58:41pm UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1 • Initial Attempt |
0% (0)0 / 24 runsfailed over last 7 days |
16.67% (4)4 / 24 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 162 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 11/28/2023 04:05:30pm UTC)
⚠️ Flakes
📄 functional/plugins/timer/timer.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Timer Can perform actions on the Timer
Retry 1 • Initial Attempt |
0% (0)0 / 18 runsfailed over last 7 days |
22.22% (4)4 / 18 runsflaked over last 7 days |
📄 functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
0% (0)0 / 18 runsfailed over last 7 days |
16.67% (3)3 / 18 runsflaked over last 7 days |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7260 +/- ##
==========================================
- Coverage 56.07% 56.06% -0.01%
==========================================
Files 654 654
Lines 26228 26228
Branches 2528 2528
==========================================
- Hits 14707 14706 -1
+ Misses 10825 10823 -2
- Partials 696 699 +3
see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -22,7 +22,7 @@ jobs: | |||
- macos-latest | |||
- windows-latest | |||
node_version: | |||
- lts/gallium | |||
- lts/iron |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a tip is also to change the .nvmrc file to lts/iron
Closes: #6732
Describe your changes:
Adds node20 to our support matrix
Removes node16 from our support matrix (EOL last september)
Ensures node 18 is the default (per @akhenry )
All Submissions:
Author Checklist
Reviewer Checklist