-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check role when receiving status updates in the Operator Status Indicator #7509
Check role when receiving status updates in the Operator Status Indicator #7509
Conversation
Note this is rather difficult to test as we need other status roles available feeding us their status changes, even when we haven't asked for them. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7509 +/- ##
==========================================
+ Coverage 55.23% 61.93% +6.69%
==========================================
Files 671 428 -243
Lines 27010 13361 -13649
Branches 2631 0 -2631
==========================================
- Hits 14919 8275 -6644
+ Misses 11361 5086 -6275
+ Partials 730 0 -730
*This pull request uses carry forward flags. Click here to find out more. see 374 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…k-for-role-when-receiving-status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #7508
Describe your changes:
Add a simple check to make sure the incoming status matches our role.
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist