Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check role when receiving status updates in the Operator Status Indicator #7509

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Feb 16, 2024

Closes #7508

Describe your changes:

Add a simple check to make sure the incoming status matches our role.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@scottbell scottbell linked an issue Feb 16, 2024 that may be closed by this pull request
7 tasks
@scottbell scottbell added this to the Target:4.0.0 milestone Feb 16, 2024
@scottbell scottbell marked this pull request as ready for review February 16, 2024 13:20
@scottbell scottbell requested a review from ozyx February 16, 2024 13:21
@scottbell
Copy link
Contributor Author

Note this is rather difficult to test as we need other status roles available feeding us their status changes, even when we haven't asked for them.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (317ea8c) 55.23% compared to head (2973a59) 61.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7509      +/-   ##
==========================================
+ Coverage   55.23%   61.93%   +6.69%     
==========================================
  Files         671      428     -243     
  Lines       27010    13361   -13649     
  Branches     2631        0    -2631     
==========================================
- Hits        14919     8275    -6644     
+ Misses      11361     5086    -6275     
+ Partials      730        0     -730     
Flag Coverage Δ *Carryforward flag
e2e-full 41.12% <ø> (ø) Carriedforward from 317ea8c
e2e-stable 59.44% <ø> (+0.05%) ⬆️
unit ?

*This pull request uses carry forward flags. Click here to find out more.

see 374 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 317ea8c...2973a59. Read the comment docs.

@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 16, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 16, 2024
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 16, 2024
@ozyx ozyx enabled auto-merge (squash) February 16, 2024 21:40
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 16, 2024
@ozyx ozyx merged commit 9870a6b into master Feb 16, 2024
21 checks passed
@ozyx ozyx deleted the 7508-operator-status-indicator-should-check-for-role-when-receiving-status branch February 16, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operator status indicator should check for role when receiving status
2 participants