-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] Allow automatic closing of panes when nav object is clicked #7553
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7553 +/- ##
==========================================
+ Coverage 56.14% 56.17% +0.02%
==========================================
Files 672 672
Lines 27128 27133 +5
Branches 2635 2635
==========================================
+ Hits 15232 15242 +10
+ Misses 11569 11564 -5
Partials 327 327
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
… desktop code which is based off resizable panes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality looks great, good work. This PR is not intended to fix the tree vs. recent objects problem (#7357) which is going to create a problem when testing. So with that, some changes:
- The original issue needs testing notes that include a callout about [Mobile Support] Object Tree is being hidden when switching from Portrait to Landscape Mode #7357. You should have the user exercise the system starting with tree collapsed and expanded, in both portrait and landscape, clicking from the tree and search results in all those permutations - except tree/landscape.
- The PR checklist and author checklists need to be completed.
Testing Instructions: #7313 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks.
Closes #7313
Describe your changes:
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist