Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeRegistry, Create Menu] implement selectable plugins for create menu #7998

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnriedel
Copy link
Contributor

@johnriedel johnriedel commented Feb 2, 2025

Closes #7725

Describe your changes:

This feature allows the user to select which plugins appear in the create menu. Details below.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Testing Instructions

  1. Click the create menu. There should be a "Select Plugins..." option.
    image
  2. Click the "Select Plugins..." option. This should open a plugin-selection dialog.
    image
  3. Deselect the "Clock" plugin and click the Ok button. Notice the Clock plugin no longer appears in the Create menu.
    image
    image
  4. Click "Select Plugins...", put a check in the Clock checkbox, and click Ok. Notice the Clock plugin appears in the Create menu.
    image
    image
  5. Create a new Clock item by clicking the Clock menu item and clicking Ok in the pop-up dialog.
    image
    image
  6. Click the Create menu, click "Select Plugins...", and notice how the Clock checkbox is disabled when the Clock plugin s in-use.
    image
  7. Close the Select Plugin dialog.
  8. Click the Create button to open the create menu. Click the Create menu button again. Notice the menu closes.

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 60.60606% with 39 lines in your changes missing coverage. Please review.

Project coverage is 57.29%. Comparing base (1fde0d9) to head (7ae8fae).

Files with missing lines Patch % Lines
...ctions/components/PluginSelectorFormController.vue 55.55% 19 Missing and 1 partial ⚠️
src/ui/layout/CreateButton.vue 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7998      +/-   ##
==========================================
- Coverage   57.62%   57.29%   -0.33%     
==========================================
  Files         678      680       +2     
  Lines       27426    27519      +93     
  Branches     2692     2708      +16     
==========================================
- Hits        15803    15768      -35     
- Misses      11281    11407     +126     
- Partials      342      344       +2     
Flag Coverage Δ
e2e-ci 62.87% <91.42%> (+0.05%) ⬆️
e2e-full 23.66% <28.57%> (-18.35%) ⬇️
unit 49.35% <51.51%> (-0.05%) ⬇️
Files with missing lines Coverage Δ
src/api/menu/components/SuperMenu.vue 83.33% <ø> (ø)
src/api/types/TypeRegistry.js 80.95% <100.00%> (+9.52%) ⬆️
src/plugins/formActions/PluginSelectorAction.js 100.00% <100.00%> (ø)
src/plugins/formActions/plugin.js 100.00% <100.00%> (ø)
src/ui/layout/CreateButton.vue 7.50% <0.00%> (-4.04%) ⬇️
...ctions/components/PluginSelectorFormController.vue 55.55% <55.55%> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fde0d9...7ae8fae. Read the comment docs.

@johnriedel johnriedel force-pushed the 7725-implement-selectable-plugins branch from 52370b4 to 7ae8fae Compare February 2, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A way to exclude default plugins?
1 participant