Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1406, Squash RTEMS sem take timeout bug #1408

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Aug 25, 2023

Checklist (Please check before submitting)

Describe the contribution

Testing performed
Ran on RTEMS 5 w/ CF semaphore flow control using counting semaphore and it worked.

Expected behavior changes

  • Squashes bug, sem take with no timeout works

System(s) tested on

  • Hardware: leon3 QEMU
  • OS: RTEMS 5
  • Versions: basically main w/ local RTEMS mods

Additional context
Opened separate issue to add functional test that covers both counting and binary semaphores

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper
Copy link
Contributor Author

skliper commented Sep 1, 2023

@dmknutsen @dzbaker - can I submit this as-is and write a follow up issue for adding the functional test?

@dzbaker
Copy link
Collaborator

dzbaker commented Sep 1, 2023

@dmknutsen @dzbaker - can I submit this as-is and write a follow up issue for adding the functional test?

That sounds good!

@skliper skliper marked this pull request as ready for review September 1, 2023 19:21
@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Sep 1, 2023
@chillfig chillfig added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Sep 7, 2023
dzbaker added a commit to nasa/cFS that referenced this pull request Sep 13, 2023
*Combines:*

cFE v7.0.0-rc4+dev384
osal v6.0.0-rc4+dev229

**Includes:**

*cFE*
- nasa/cFE#2437

*osal*
- nasa/osal#1407
- nasa/osal#1408

Co-authored by: Justin Figueroa <[email protected]>
Co-authored by: Jacob Hageman  <[email protected]>
@dzbaker dzbaker mentioned this pull request Sep 13, 2023
2 tasks
@dzbaker dzbaker merged commit 5a0741f into nasa:main Sep 13, 2023
20 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Sep 13, 2023
*Combines:*

cFE v7.0.0-rc4+dev384
osal v6.0.0-rc4+dev229

**Includes:**

*cFE*
- nasa/cFE#2437

*osal*
- nasa/osal#1407
- nasa/osal#1408

Co-authored by: Justin Figueroa <[email protected]>
Co-authored by: Jacob Hageman  <[email protected]>
@skliper skliper deleted the fix1406-rtems_countsem_timeout_bug branch April 1, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling OS_CountSemTimedWait on RTEMS with 0 timeout waits forever
3 participants