Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 104 add history attributes #113

Merged
merged 13 commits into from
Mar 19, 2024

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Mar 5, 2024

GitHub Issue: #104

Description

Adds history_json attribute to output netCDF — to follow TRT-42.

Local test steps

  • Tested as local Python package (without Harmony) on granules from TEMPO_NO2_L2_V01 scan 1 (S001, starting at 20130701T131154Z). Confirmed history_json global attribute was present in output netCDF file with schema, date_time, program, version, parameters, derived_from, and program_ref keys.

Overview of integration done

  • Tested in local Harmony environment using harmony-py request with Temporal, Spatial and Variable subsettings resulting in use of 24 granules (12 stitchee instances). history_json was present in the output file. See screenshot in the comments below.

PR Acceptance Checklist

  • Unit tests added/updated and passing.
  • Integration testing
  • CHANGELOG.md updated
  • Documentation updated (if needed).

@danielfromearth danielfromearth linked an issue Mar 6, 2024 that may be closed by this pull request
@danielfromearth danielfromearth added the enhancement New feature or request label Mar 6, 2024
@ank1m
Copy link
Collaborator

ank1m commented Mar 7, 2024

I ran this version of stitchee locally and have history_json in the output file:
image

@danielfromearth
Copy link
Collaborator Author

danielfromearth commented Mar 18, 2024

I ran this version of stitchee locally and have history_json in the output file:

I think it generally looks good to me, though the l2ss-py history appears to be missing the variable information, so I created an issue here: podaac/l2ss-py#246

@ank1m, did you notice anything amiss? Otherwise I think this is ready to merge.

@ank1m
Copy link
Collaborator

ank1m commented Mar 19, 2024

the only problem I see is that in Panoply it tries to display the whole history in one line, making it unreadable. It's more of a Panoply issue than ours though.

@danielfromearth danielfromearth merged commit f6c641e into develop Mar 19, 2024
4 checks passed
@danielfromearth danielfromearth deleted the feature/issue-104-add-history-attributes branch March 19, 2024 13:28
@danielfromearth danielfromearth mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add provenance information about the stitchee operation
2 participants