Added 'fit_single_trees' argument to volcanoes config files. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Error: File "*/dora/.venv/lib/python3.8/site-packages/dora_exp_pipeline/outlier_detection.py", line 69, in run
results = self._rank_internal(dtf, dts, dts_ids, top_n, seed, **kwargs)
TypeError: _rank_internal() missing 1 required positional argument: 'fit_single_trees'
Fixed bug: File "*/dora/.venv/lib/python3.8/site-packages/dora_exp_pipeline/outlier_detection.py", line 69, in run
results = self._rank_internal(dtf, dts, dts_ids, top_n, seed, **kwargs)
TypeError: _rank_internal() missing 1 required positional argument: 'fit_single_trees'
anatarano
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Missing argument
fit_single_treesinsample_dataconfig files for volcano patches and pixels for Isolation forest (iForest) method.Bug
Patches
Command line:
dora_exp sample_data/earth_volcanoes/exp/patches/earth_volcanoes_patches.ymlError: File "*/dora/.venv/lib/python3.8/site-packages/dora_exp_pipeline/outlier_detection.py", line 69, in run
results = self._rank_internal(dtf, dts, dts_ids, top_n, seed, **kwargs)
TypeError: _rank_internal() missing 1 required positional argument: 'fit_single_trees'
Pixels
Command line:
dora_exp sample_data/earth_volcanoes/exp/pixels/earth_volcanoes_pixels.ymlError: File "*/dora/.venv/lib/python3.8/site-packages/dora_exp_pipeline/outlier_detection.py", line 69, in run
results = self._rank_internal(dtf, dts, dts_ids, top_n, seed, **kwargs)
TypeError: _rank_internal() missing 1 required positional argument: 'fit_single_trees'
Validation
Tested on the master branch. Reproduced the results from
/*/dora/test/ref-results/earth_volcanoes_pixels/iforest-n_trees=100-fit_single_trees=False/selections-iforest.csvand/*/dora/test/ref-results/earth_volcanoes_patches/iforest-n_trees=100-fit_single_trees=False/selections-iforest.csv.