Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for literals #83

Merged
merged 7 commits into from
Jul 10, 2024
Merged

Add tests for literals #83

merged 7 commits into from
Jul 10, 2024

Conversation

plotchy
Copy link
Collaborator

@plotchy plotchy commented Jun 27, 2024

There are some failing tests around:

rational number literal:

  • negatives aren't allowed (but are valid)
  • some numerator/denominator math seems off (23.5e5 -> 150000000)
  • all of these get set to 256 bit size when they can be smaller

too large negative numbers dont err

string evaluation doesn't occur

@plotchy plotchy force-pushed the plotchy/literals branch from c10824b to 28f969f Compare June 28, 2024 21:02
@plotchy
Copy link
Collaborator Author

plotchy commented Jun 28, 2024

updated for GraphErr and ExprErr refactor

@brockelmore brockelmore merged commit 44ec8f1 into master Jul 10, 2024
1 check passed
@brockelmore brockelmore deleted the plotchy/literals branch July 12, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants