Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expression filter_recursion shouldn't arenaize #85

Closed
wants to merge 1 commit into from
Closed

fix: expression filter_recursion shouldn't arenaize #85

wants to merge 1 commit into from

Conversation

plotchy
Copy link
Collaborator

@plotchy plotchy commented Jul 3, 2024

chatted on call about this.

prevents a cycle from forming in the arena on arrays when calling create_length()

@plotchy
Copy link
Collaborator Author

plotchy commented Jul 3, 2024

looks like this is causing the failure of test_cast?

@brockelmore brockelmore mentioned this pull request Jul 11, 2024
Merged
@brockelmore
Copy link
Contributor

Closed in favor of #87

@brockelmore brockelmore deleted the plotchy/expr_filter_recursion_fix branch July 12, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plotchy @brockelmore