IAM-224-run tests #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use ruff instead of flake8 * fix statich check * remove complexity lint
Co-authored-by: Github Actions <[email protected]>
Co-authored-by: Github Actions <[email protected]>
* use pyright instead of mypy * fix unit tests * re-add accidental deletion * actually fix tests * ignore line in pyright * satisfy linter
* metrics endpoint generated using fqdn * fix static checks * update libjuju version
…ical#223) * Lock Pyright version to fix CI flakiness on canonical/operator See https://github.com/canonical/operator/actions/runs/5384117730/jobs/9771655581?pr=957 * Fix type checking issue with service_ports This worked in Pyright 1.1.314, but not in 1.1.315 or 1.1.316. The type of service_ports is List[Tuple[str, Literal[3000], Literal[3000]]], which doesn't type check as List[Tuple[str, int, int]] -- which is very unintuitive, but oh well. I believe this is by design, see microsoft/pyright#5366 and https://microsoft.github.io/pyright/#/type-inference?id=tuple-expressions The Pyright fixes were probably one of microsoft/pyright#5321 or microsoft/pyright#5323
Co-authored-by: Github Actions <[email protected]>
* WIP: Implement TLS * add requirements * fix tests and linting * fix many things * fix grafana restart * fix lint * some fixes * fix itests * fix linter * fetch libs * use external_url and revert external lib changes * trust the cos ca * fix unit tests * fix linter * fix static check * fix itests once and for all * correctly trust ca * get the ca from the correct relation info * address PR comments * fix linter * update cert_handler
Co-authored-by: Github Actions <[email protected]>
* Do not assume pw changed on http error * Add useful log line * Interpret empty response as "not ready" * Rename 'grafana_server' to 'grafana_client' * Add scheme to grafana_client * Remove CodeQL workflow * Client: add timeout * Install CA in charm container as well so we can verify
Update response for action get-admin-password to return both dashboard url and initial admin password. Closes canonical#92
* add proxy config from env variables * linter fixes * charmcraft fetch-lib * fix unit tests
* fetch-lib * Use strip_prefix in favor of web_external_url * Use open-port instead of service patch * Add blank scenario env
* Fix lint issues in grafana dashboard library Grafana dashboard library has lint issues with following error. E721 Do not compare types, use `isinstance()` Fix as per the lint recommendation. * Update lib/charms/grafana_k8s/v0/grafana_dashboard.py --------- Co-authored-by: Simon Aronsson <[email protected]>
…nical#247) * fix tox.ini * load dashboards from disk when relation is created * linting * store dashboards in pebble ready (after shutdown) * add _update_dashboards() method
Co-authored-by: Github Actions <[email protected]>
* update libs * now web ui is reachable * fix inclusive naming
* remove insecure-skip-verify for HTTPS datasources * charmcraft fetch-lib
* Revert "FIX: web UI unreachable (canonical#253)" * fetch-lib * Add bundles for manual testing * Drop config entries in favor of envvars.
pass oauth config as env variables fix mypy issue address review comments
send new client config to oauth relation on config_changed event address review comments fix lint
fix pyright check error fix relation-broken event, change oauth provider name fix integration tests fix rebase issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Solution
Context
Testing Instructions
Release Notes