Store real end of stack when thread suspends for amd64 #2640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the amount of memory the GC needs to scan during pauses. Before, we were scanning the full 8 Mb or whatever of stack space for each thread; now we just scan what is actually in use.
Using this code as a benchmark:
The results are dramatic:
Caveats:
This doesn't help on Darwin, as we use a different technique to suspend Darwin threads.
I don't have an Arm processor with Linux, so I'm not sure what kind of code we'd need for that. We can add other architectures later.